etseidl commented on code in PR #6313:
URL: https://github.com/apache/arrow-rs/pull/6313#discussion_r1779167027
##########
parquet/src/arrow/arrow_reader/statistics.rs:
##########
@@ -371,8 +371,7 @@ macro_rules! get_statistics {
[<$stat_type_prefix
Int32StatsIterator>]::new($iterator).map(|x| x.copied()),
))),
DataType::Date64 => Ok(Arc::new(Date64Array::from_iter(
- [<$stat_type_prefix Int32StatsIterator>]::new($iterator)
- .map(|x| x.map(|x| i64::from(*x) * 24 * 60 * 60 * 1000)),
+ [<$stat_type_prefix
Int64StatsIterator>]::new($iterator).map(|x| x.copied()),
Review Comment:
The `Statistics` struct keeps the parquet physical type info, but I'm not
sure how to get at it here. 🤔
We have to know whether the physical type is INT32 or INT64, and if INT32 we
still have to do the scaling of days to milliseconds (and use the
`Int32StatsIterator`). Perhaps add physical type to the `StatisticsConverter`
struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
