alamb opened a new pull request, #6479:
URL: https://github.com/apache/arrow-rs/pull/6479

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes https://github.com/apache/arrow-rs/issues/6478
   
   # Rationale for this change
    
   # Rationale for this change
   
   While working with StringViewArray's downstream in DataFusion, I found it 
was not always that `ByteView` exists for creating/destructuring with the 
`u128`s so I wanted to write some additional documentation
   I also found it quite awkward to write the examples (specifically setting 
the prefix) so I added some BuilderStyle APIs as well
   
   This is what creating ByteViews looks like without the builder APIs :vomit:
   
   ```rust
   let view = ByteView {
      length: 12,
      // convert 4 byte &str to u32
      prefix: u32::from_le_bytes(prefix.as_bytes().try_into().unwrap()),
      buffer_index: 3,
      offset: 42,
   };
   ```
   
   # What changes are included in this PR?
   1. Add pointer to `GenericByteViewArray` from docs
   2. Add examples of using `ByteView`
   3. Add builder style APIs to `ByteView`
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to