etseidl commented on code in PR #6474:
URL: https://github.com/apache/arrow-rs/pull/6474#discussion_r1779740884
##########
parquet/src/file/metadata/reader.rs:
##########
@@ -329,13 +329,18 @@ impl ParquetMetaDataReader {
return Ok(());
}
- self.load_page_index(fetch, remainder).await
+ self.load_page_index_with_remainder(fetch, remainder).await
}
/// Asynchronously fetch the page index structures when a
[`ParquetMetaData`] has already
/// been obtained. See [`Self::new_with_metadata()`].
#[cfg(feature = "async")]
- pub async fn load_page_index<F: MetadataFetch>(
+ pub async fn load_page_index<F: MetadataFetch>(&mut self, fetch: F) ->
Result<()> {
Review Comment:
This change will be breaking if in 52.2.0. I'll revert this if need be. I
found having `remainder` in the public API confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
