erratic-pattern commented on PR #6518: URL: https://github.com/apache/arrow-rs/pull/6518#issuecomment-2400688183
> I think this runs the risk of inadvertently exposing details that shouldn't be rendered in logs, I therefore think we should instead look to improve the logging in a more targeted fashion. So I think there's two ways to go about this: 1. move away from `snafu` and do explicit `Display` impls that show more information about the `reqwest` error. 2. convert `reqwest::Error` to a new internal wrapper type which classifies the errors based on category and includes information like cause, and provides its own `snafu`-based `Display` implementation so that we can customize how `reqwest` errors are displayed. Do you have any preference here? I think the latter is possibly a cleaner option. I'd just like to get some kind of permission before I go mucking around with the existing error conventions in the library. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
