kou commented on code in PR #44341: URL: https://github.com/apache/arrow/pull/44341#discussion_r1792548280
########## c_glib/test/test-stream-decoder.rb: ########## @@ -79,8 +79,15 @@ def test_consume_bytes end def test_consume_buffer + # We need to keep data that aren't processed yet. Review Comment: No. We don't need to change `test_consume_bytes`. `arrow::ipc::StreamDecoder::Consume(const uint8_t* data, int64_t size)` copied the given data internally when they aren't enough size. (`arrow::ipc::StreamDecoder::Consume(std::shared_ptr<Buffer> buffer)` refers them instead of copying.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
