ripplehang commented on code in PR #43601:
URL: https://github.com/apache/arrow/pull/43601#discussion_r1793489678
##########
cpp/src/arrow/filesystem/s3fs_test.cc:
##########
@@ -532,15 +549,17 @@ class TestS3FS : public S3TestMixin {
Result<std::shared_ptr<S3FileSystem>> MakeNewFileSystem(
io::IOContext io_context = io::default_io_context()) {
options_.ConfigureAccessKey(minio_->access_key(), minio_->secret_key());
- options_.scheme = "http";
+ options_.scheme = minio_->scheme();
options_.endpoint_override = minio_->connect_string();
if (!options_.retry_strategy) {
options_.retry_strategy = std::make_shared<ShortRetryStrategy>();
}
return S3FileSystem::Make(options_, io_context);
}
- void MakeFileSystem() { ASSERT_OK_AND_ASSIGN(fs_, MakeNewFileSystem()); }
+ void MakeFileSystem() {
+ ASSERT_OK_AND_ASSIGN(fs_, MakeNewFileSystem(io::default_io_context()));
Review Comment:
this should be unnecessary now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
