zeroshade commented on issue #150: URL: https://github.com/apache/arrow-go/issues/150#issuecomment-2402846698
Yea, because asm2plan9s is archived, I've ended up doing a lot of jumping through hoops to make sure that the code we generate and otherwise use is valid and has definitely resulted in many cases where I manually edit the generated assembly to make everything work. Your proposed fix seems to make sense to me, have you tried using it locally in your reproducer? (does it solve the issue?) I don't think any of our tests currently test while using tracing, which explains why we haven't run into this. Much of the current arm64 neon assembly used in here was generated by a C compiler and then transpiled to plan9 via asm2plan9s after a bunch of very manual changes and fixes by me and some others. Maybe we could create a simple `sed` regex script that could identify and fix this issue in the arm64 neon assembly that we could run on it (instead of having to do it manually)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
