rok commented on code in PR #41821:
URL: https://github.com/apache/arrow/pull/41821#discussion_r1794278960
##########
cpp/src/parquet/metadata.cc:
##########
@@ -894,6 +894,13 @@ class FileMetaData::FileMetaDataImpl {
out->impl_->key_value_metadata_ = key_value_metadata_;
out->impl_->file_decryptor_ = file_decryptor_;
+ if (key_value_metadata_ &&
key_value_metadata_->Contains("row_group_aad_0")) {
+ PARQUET_ASSIGN_OR_THROW(
+ auto aad,
+ key_value_metadata_->Get("row_group_aad_" +
std::to_string(row_groups[0])));
+ out->set_file_decryptor_aad(aad);
+ }
Review Comment:
@pitrou regarding your suggestion to avoid storing AADs as
`key_value_metadata` entries and instead read them from files at dataset scan
time - do you have a suggestion on how/where to detect we'll no longer be
reading `_metadata` file but rather data files? If we can do that we can change
the decryptor's AAD there and read the desired data file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
