lidavidm commented on code in PR #44241:
URL: https://github.com/apache/arrow/pull/44241#discussion_r1794705239
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileReader.java:
##########
@@ -910,7 +910,9 @@ private void readFromJsonIntoVector(Field field,
FieldVector vector) throws IOEx
}
int nullCount = 0;
- if (type instanceof ArrowType.Null) {
+ if (type instanceof ArrowType.RunEndEncoded) {
Review Comment:
What I mean is
```
if (run end || union) {
nullCount = 0;
} else if (null) {
nullCount = valueCount;
} else {
// compute null count since it is not run end, union, or null
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
