kou commented on PR #44365: URL: https://github.com/apache/arrow/pull/44365#issuecomment-2404469591
I'm not sure when we need `ARROW_EXPORT`... For example, https://github.com/apache/arrow/pull/44365/commits/a365cbf64601bc030202aab32a4fbe3e88d64b76 is needed... Here is the error message without it: https://github.com/apache/arrow/actions/runs/11268303462/job/31334825247#step:9:1229 ```text D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(178): error C2220: the following warning is treated as an error D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(178): warning C4661: 'int32_t arrow::SmallBasicDecimal<int32_t>::CountLeadingBinaryZeros(void) const': no suitable definition provided for explicit template instantiation request D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(244): note: see declaration of 'arrow::SmallBasicDecimal<int32_t>::CountLeadingBinaryZeros' D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(178): warning C4661: 'int32_t arrow::SmallBasicDecimal<int64_t>::CountLeadingBinaryZeros(void) const': no suitable definition provided for explicit template instantiation request D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(244): note: see declaration of 'arrow::SmallBasicDecimal<int64_t>::CountLeadingBinaryZeros' D:\a\arrow\arrow\build\cpp\src\arrow\CMakeFiles\arrow_io_shared.dir\Unity\unity_0_cxx.cxx(27): warning C4661: 'int32_t arrow::SmallBasicDecimal<int32_t>::CountLeadingBinaryZeros(void) const': no suitable definition provided for explicit template instantiation request D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(244): note: see declaration of 'arrow::SmallBasicDecimal<int32_t>::CountLeadingBinaryZeros' D:\a\arrow\arrow\build\cpp\src\arrow\CMakeFiles\arrow_io_shared.dir\Unity\unity_0_cxx.cxx(27): warning C4661: 'int32_t arrow::SmallBasicDecimal<int64_t>::CountLeadingBinaryZeros(void) const': no suitable definition provided for explicit template instantiation request D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(244): note: see declaration of 'arrow::SmallBasicDecimal<int64_t>::CountLeadingBinaryZeros' D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(192): warning C4661: 'int32_t arrow::SmallBasicDecimal<int32_t>::CountLeadingBinaryZeros(void) const': no suitable definition provided for explicit template instantiation request D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(244): note: see declaration of 'arrow::SmallBasicDecimal<int32_t>::CountLeadingBinaryZeros' D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(192): warning C4661: 'int32_t arrow::SmallBasicDecimal<int64_t>::CountLeadingBinaryZeros(void) const': no suitable definition provided for explicit template instantiation request D:\a\arrow\arrow\cpp\src\arrow/util/basic_decimal.h(244): note: see declaration of 'arrow::SmallBasicDecimal<int64_t>::CountLeadingBinaryZeros' [184/608] Building CXX object src\arrow\CMakeFiles\arrow_array_shared.dir\Unity\unity_2_cxx.cxx.obj ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
