tustvold commented on code in PR #6539:
URL: https://github.com/apache/arrow-rs/pull/6539#discussion_r1795268498
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -3077,6 +3077,119 @@ mod tests {
);
}
+ #[test]
+ fn test_read_binary_as_utf8() {
+ let file = write_parquet_from_iter(vec![
+ (
+ "binary_to_utf8",
+ Arc::new(BinaryArray::from(vec![
+ b"one".as_ref(),
+ b"two".as_ref(),
+ b"three".as_ref(),
+ ])) as ArrayRef,
+ ),
+ (
+ "large_binary_to_large_utf8",
+ Arc::new(LargeBinaryArray::from(vec![
+ b"one".as_ref(),
+ b"two".as_ref(),
+ b"three".as_ref(),
+ ])) as ArrayRef,
+ ),
+ (
+ "binary_view_to_utf8_view",
+ Arc::new(BinaryViewArray::from(vec![
+ b"one".as_ref(),
+ b"two".as_ref(),
+ b"three".as_ref(),
+ ])) as ArrayRef,
+ ),
+ ]);
+ let supplied_fields = Fields::from(vec![
+ Field::new("binary_to_utf8", ArrowDataType::Utf8, false),
+ Field::new(
+ "large_binary_to_large_utf8",
+ ArrowDataType::LargeUtf8,
+ false,
+ ),
+ Field::new("binary_view_to_utf8_view", ArrowDataType::Utf8View,
false),
+ ]);
+
+ let options =
ArrowReaderOptions::new().with_schema(Arc::new(Schema::new(supplied_fields)));
+ let mut arrow_reader =
ParquetRecordBatchReaderBuilder::try_new_with_options(
+ file.try_clone().unwrap(),
+ options,
+ )
+ .expect("reader builder with schema")
+ .build()
+ .expect("reader with schema");
+
+ let batch = arrow_reader.next().unwrap().unwrap();
+ assert_eq!(batch.num_columns(), 3);
+ assert_eq!(batch.num_rows(), 3);
+ assert_eq!(
+ batch
+ .column(0)
+ .as_any()
+ .downcast_ref::<StringArray>()
+ .expect("downcast to string")
+ .iter()
+ .collect::<Vec<_>>(),
+ vec![Some("one"), Some("two"), Some("three")]
+ );
+
+ assert_eq!(
+ batch
+ .column(1)
+ .as_any()
+ .downcast_ref::<LargeStringArray>()
+ .expect("downcast to large string")
+ .iter()
+ .collect::<Vec<_>>(),
+ vec![Some("one"), Some("two"), Some("three")]
+ );
+
+ assert_eq!(
+ batch
+ .column(2)
+ .as_any()
+ .downcast_ref::<StringViewArray>()
+ .expect("downcast to string view")
+ .iter()
+ .collect::<Vec<_>>(),
+ vec![Some("one"), Some("two"), Some("three")]
+ );
+ }
+
+ #[test]
+ #[should_panic(expected = "Invalid UTF8 sequence at")]
+ fn test_read_non_utf8_binary_as_utf8() {
+ let file = write_parquet_from_iter(vec![(
+ "non_utf8_binary",
+ Arc::new(BinaryArray::from(vec![
+ b"\xDE\x00\xFF".as_ref(),
+ b"\xDE\x01\xAA".as_ref(),
+ b"\xDE\x02\xFF".as_ref(),
+ ])) as ArrayRef,
+ )]);
+ let supplied_fields = Fields::from(vec![Field::new(
+ "non_utf8_binary",
+ ArrowDataType::Utf8,
+ false,
+ )]);
+
+ let options =
ArrowReaderOptions::new().with_schema(Arc::new(Schema::new(supplied_fields)));
+ let mut arrow_reader =
ParquetRecordBatchReaderBuilder::try_new_with_options(
+ file.try_clone().unwrap(),
+ options,
+ )
+ .expect("reader builder with schema")
+ .build()
+ .expect("reader with schema");
+
+ arrow_reader.next();
Review Comment:
```suggestion
arrow_reader.next().unwrap_err();
```
As this should error, given the data isn't actually UTF-8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
