raulcd commented on code in PR #44375:
URL: https://github.com/apache/arrow/pull/44375#discussion_r1796676672
##########
ci/docker/python-wheel-windows-vs2019.dockerfile:
##########
@@ -84,7 +84,7 @@ RUN (if "%python%"=="3.9" setx PYTHON_VERSION "3.9.13" &&
setx PATH "%PATH%;C:\P
(if "%python%"=="3.10" setx PYTHON_VERSION "3.10.11" && setx PATH
"%PATH%;C:\Python310;C:\Python310\Scripts") & \
(if "%python%"=="3.11" setx PYTHON_VERSION "3.11.9" && setx PATH
"%PATH%;C:\Python311;C:\Python311\Scripts") & \
(if "%python%"=="3.12" setx PYTHON_VERSION "3.12.5" && setx PATH
"%PATH%;C:\Python312;C:\Python312\Scripts") & \
- (if "%python%"=="3.13" setx PYTHON_VERSION "3.13.0-rc1" && setx PATH
"%PATH%;C:\Python313;C:\Python313\Scripts")
+ (if "%python%"=="3.13" setx PYTHON_VERSION "3.13.0" && setx PATH
"%PATH%;C:\Python313;C:\Python313\Scripts")
Review Comment:
`3.13.0` is still not on chocolatey, see:
https://community.chocolatey.org/packages/python313
That's why it fails
##########
ci/docker/python-wheel-windows-vs2019.dockerfile:
##########
@@ -84,7 +84,7 @@ RUN (if "%python%"=="3.9" setx PYTHON_VERSION "3.9.13" &&
setx PATH "%PATH%;C:\P
(if "%python%"=="3.10" setx PYTHON_VERSION "3.10.11" && setx PATH
"%PATH%;C:\Python310;C:\Python310\Scripts") & \
(if "%python%"=="3.11" setx PYTHON_VERSION "3.11.9" && setx PATH
"%PATH%;C:\Python311;C:\Python311\Scripts") & \
(if "%python%"=="3.12" setx PYTHON_VERSION "3.12.5" && setx PATH
"%PATH%;C:\Python312;C:\Python312\Scripts") & \
Review Comment:
Not strictly required but we can update to the latest on chocolatey.
```suggestion
(if "%python%"=="3.12" setx PYTHON_VERSION "3.12.6" && setx PATH
"%PATH%;C:\Python312;C:\Python312\Scripts") & \
```
##########
ci/docker/python-wheel-windows-test-vs2019.dockerfile:
##########
@@ -54,7 +54,7 @@ RUN (if "%python%"=="3.9" setx PYTHON_VERSION "3.9.13") & \
(if "%python%"=="3.10" setx PYTHON_VERSION "3.10.11") & \
(if "%python%"=="3.11" setx PYTHON_VERSION "3.11.9") & \
(if "%python%"=="3.12" setx PYTHON_VERSION "3.12.5") & \
Review Comment:
Not strictly required but we can update to the latest on chocolatey.
```suggestion
(if "%python%"=="3.12" setx PYTHON_VERSION "3.12.6") & \
```
##########
ci/scripts/install_python.sh:
##########
@@ -47,17 +47,11 @@ full_version=${versions[$2]}
if [ $platform = "macOS" ]; then
echo "Downloading Python installer..."
- if [ "$version" = "3.13" ] || [ "$version" = "3.13t" ];
+ if [ "$(uname -m)" = "x86_64" ] && [ "$version" = "3.9" ];
Review Comment:
LGTM, can you also update
https://github.com/apache/arrow/pull/44375/files#diff-404e24b955d9320a7b3db90149855e38c86133f626f8b555002212293e79ad80L31
to:
```
[3.12]=3.12.7
```
This is the latest with packages (`.pkg`) on
https://www.python.org/ftp/python/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
