crepererum commented on issue #6377: URL: https://github.com/apache/arrow-rs/issues/6377#issuecomment-2407059155
Regarding the argument that @tustvold brought up here: https://github.com/apache/arrow-rs/pull/6518#issuecomment-2400700542 and that basically boils down to "people should walk the error chain": I think the issue here is that `object_store` is somewhat inconsistent: for some errors, `Display` prints the entire chain `e1: e2: e3` but for `reqwest` errors it does not. That also make the proposal to "walk the error chain" somewhat impractical, because if you walk the chain and use `Display` to print the chain parts, you gonna repeat some errors. So our standpoint is to really tell people that the chain should be walked, then stuff like this https://github.com/apache/arrow-rs/blob/4adbeee14c40c080f8fca3bd42c0c3856bbb151c/object_store/src/aws/client.rs#L69-L70 is wrong and ```rust #[snafu(display("Error bla bla: {}", source))] ``` should be ```rust #[snafu(display("Error bla bla"))] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
