zeroshade commented on code in PR #2214:
URL: https://github.com/apache/arrow-adbc/pull/2214#discussion_r1800139259
##########
csharp/test/Apache.Arrow.Adbc.Tests/Metadata/GetObjectsParser.cs:
##########
@@ -30,10 +30,9 @@ public class GetObjectsParser
/// Parses a <see cref="RecordBatch"/> from a GetObjects call for the
<see cref="AdbcCatalog"/>.
/// </summary>
/// <param name="recordBatch"></param>
- /// <param name="databaseName"></param>
/// <param name="schemaName"></param>
/// <returns></returns>
- public static List<AdbcCatalog> ParseCatalog(RecordBatch recordBatch,
string? databaseName, string? schemaName)
+ public static List<AdbcCatalog> ParseCatalog(RecordBatch recordBatch,
string? schemaName)
Review Comment:
Why remove the databaseName param?
##########
csharp/src/Drivers/Interop/FlightSql/copyFlightSqlDriver.sh:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+### copies the Snowflake binaries for all platforms to be packaged for NuGet
+
+echo "Copying the Snowflake ADBC Go drivers"
Review Comment:
```suggestion
echo "Copying the FlightSQL ADBC Go driver"
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
