khwilson commented on PR #44184: URL: https://github.com/apache/arrow/pull/44184#issuecomment-2415588449
Nice! I'm excited for the checked variants of sum and product! With the integer overflow example, I only meant to point out that the compute module currently allows overflows, so I think it would be unexpected for `sum` to complain about an overflow _only_ if the underlying type was a decimal. But if the goal with #37090 is to _replace_ `sum` with a checked version, then the solution of erroring makes a lot of sense, and I'd be happy to implement it when #37536 gets merged. :-) Still, I do think that users would find it unexpected to get an error if the sum fit in the underlying storage since this is how all the databases I've used (and the four I surveyed in #35166) have operated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
