Lukedowling444 opened a new pull request, #44434:
URL: https://github.com/apache/arrow/pull/44434
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
In the current implementation of the pyarrow.scalar constructor, when an
input has the __arrow_c_array__ interface, there is no check to ensure the
length of the array is exactly 1. This can lead to unexpected behavior or
invalid data being accepted for scalar construction.
This change introduces a validation step that checks whether the input array
has a length of 1 when using the __arrow_c_array__ interface, ensuring that
only valid inputs are processed. This improves the reliability of Arrow when
handling data from multiple libraries.
An existing workaround involves calling pa.array(other_scalar).slice(0, 1)
to achieve the same result, but this change eliminates the need for such a
workaround.
Looking to close #44232
### What changes are included in this PR?
A validation check was added inside the pyarrow.scalar constructor to ensure
that when an input with the __arrow_c_array__ interface is provided, it must be
a length-1 array.
The constructor now raises a ValueError if this condition is not met.
### Are these changes tested?
Yes, the project builds successfully, and all existing test cases pass
without any issues.
Additionally, I have included new test cases to specifically check the
behavior of this change in python/scripts/test_scalar.py. These tests ensure
that the pyarrow.scalar constructor raises a ValueError when a non-length-1
array is provided and continues to work correctly for valid inputs.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
### Are there any user-facing changes?
No user-facing changes are introduced, and this validation should not affect
any workflows where inputs to pyarrow.scalar are already correct.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line
below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
GitHub Issue: https://github.com/apache/arrow/issues/44232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
