WillAyd commented on code in PR #644:
URL: https://github.com/apache/arrow-nanoarrow/pull/644#discussion_r1803398859
##########
python/src/nanoarrow/__init__.py:
##########
@@ -75,7 +77,8 @@
from nanoarrow.array import array, Array
from nanoarrow.array_stream import ArrayStream
from nanoarrow.visitor import nulls_as_sentinel, nulls_forbid, nulls_separate
-from nanoarrow._version import __version__ # noqa: F401
+
+__version__ = importlib.metadata.version("nanoarrow")
Review Comment:
I think I accidentally removed the comment, but the downside to this
approach versus a dynamic version generator like miniver is that the git hash
is not included as part of the project metadata.
In this case the project definition from pyproject.toml just imports
whatever the build-backend provides, which is currently 0.7.0-SNAPSHOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
