alamb commented on code in PR #6572:
URL: https://github.com/apache/arrow-rs/pull/6572#discussion_r1803671720
##########
arrow-integration-testing/src/lib.rs:
##########
@@ -165,7 +165,7 @@ pub fn read_gzip_json(version: &str, path: &str) ->
ArrowJson {
/// C Data Integration entrypoint to export the schema from a JSON file
fn cdata_integration_export_schema_from_json(
- c_json_name: *const i8,
+ c_json_name: *const c_char,
out: *mut FFI_ArrowSchema,
) -> Result<()> {
let json_name = unsafe { CStr::from_ptr(c_json_name) };
Review Comment:
It is strange to me that the signature in `std::ffi` is `ptr: *const i8`,
not `*const c_char` 🤔
https://doc.rust-lang.org/std/ffi/struct.CStr.html#method.from_ptr
Maybe it changed in 1.82 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
