alamb commented on code in PR #6573:
URL: https://github.com/apache/arrow-rs/pull/6573#discussion_r1803672805
##########
arrow-schema/src/ffi.rs:
##########
@@ -336,7 +336,7 @@ impl FFI_ArrowSchema {
Ok(HashMap::new())
} else {
let mut pos = 0;
- let buffer: *const u8 = self.metadata as *const u8;
+ let buffer: *const u8 = self.metadata;
Review Comment:
this appears to not compile on CI 🤔
e.g.
https://github.com/apache/arrow-rs/actions/runs/11370592216/job/31636347622?pr=6573
```
Run cargo test -p arrow-data --all-features
Compiling bitflags v2.6.0
Compiling arrow-schema v53.1.0 (/__w/arrow-rs/arrow-rs/arrow-schema)
error[E0308]: mismatched types
-->
arrow-schema/src/ffi.rs:339:3[7](https://github.com/apache/arrow-rs/actions/runs/11370592216/job/31636347622?pr=6573#step:6:8)
|
339 | let buffer: *const
u[8](https://github.com/apache/arrow-rs/actions/runs/11370592216/job/31636347622?pr=6573#step:6:9)
= self.metadata;
| --------- ^^^^^^^^^^^^^ expected `*const
u8`, found `*const i8`
| |
| expected due to this
|
= note: expected raw pointer `*const u8`
found raw pointer `*const i8`
For more information about this error, try `rustc --explain E0308`.
error: could not compile `arrow-schema` (lib) due to 1 previous error
Error: Process completed with exit code
[10](https://github.com/apache/arrow-rs/actions/runs/11370592216/job/31636347622?pr=6573#step:6:11)1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
