zeroshade commented on code in PR #2254:
URL: https://github.com/apache/arrow-adbc/pull/2254#discussion_r1805123443
##########
c/validation/adbc_validation_statement.cc:
##########
@@ -2180,15 +2180,15 @@ void StatementTest::TestSqlBind() {
ASSERT_THAT(
AdbcStatementSetSqlQuery(
- &statement, "SELECT * FROM bindtest ORDER BY \"col1\" ASC NULLS
FIRST", &error),
+ &statement, "SELECT * FROM bindtest ORDER BY col1 ASC NULLS FIRST",
&error),
Review Comment:
It's more about consistency. Our `CREATE TABLE` query earlier in this
function doesn't quote the column names, so our select statement needs to also
*not* quote the names. Almost everywhere else we quote the columns. We just
need to be consistent.
That said, I agree with it would be awesome for these tests to be more
data-driven.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
