lidavidm commented on code in PR #165:
URL: https://github.com/apache/arrow-go/pull/165#discussion_r1805587959
##########
arrow/array/string_test.go:
##########
@@ -90,9 +90,6 @@ func TestStringArray(t *testing.T) {
if got, want := arr.ValueOffset(i), int(offsets[i]); got !=
want {
t.Fatalf("arr-offset-beg[%d]: got=%d, want=%d", i, got,
want)
}
- if got, want := arr.ValueOffset(i+1), int(offsets[i+1]); got !=
want {
Review Comment:
I guess we could validate ValueLen instead? Though maybe not really worth it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
