pitrou commented on code in PR #44468:
URL: https://github.com/apache/arrow/pull/44468#discussion_r1806749389
##########
cpp/src/arrow/util/ubsan.h:
##########
@@ -63,7 +63,7 @@ inline std::enable_if_t<std::is_trivially_copyable_v<T>, T>
SafeLoadAs(
template <typename T>
inline std::enable_if_t<std::is_trivially_copyable_v<T>, T> SafeLoad(const T*
unaligned) {
std::remove_const_t<T> ret;
- std::memcpy(&ret, unaligned, sizeof(T));
+ std::memcpy(&ret, reinterpret_cast<const void*>(unaligned), sizeof(T));
Review Comment:
I think I'd rather merge without `std::launder` for now. We can reevaluate
later if the issue arises, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
