amol- commented on code in PR #44447:
URL: https://github.com/apache/arrow/pull/44447#discussion_r1807812463


##########
python/pyarrow/array.pxi:
##########
@@ -538,6 +538,51 @@ def repeat(value, size, MemoryPool memory_pool=None):
     return pyarrow_wrap_array(c_array)
 
 
+def mask(indices, length, MemoryPool memory_pool=None):
+    """
+    Create a boolean Array instance where specific indices are marked as True.
+
+    Parameters
+    ----------
+    indices : list[int]

Review Comment:
   If I remember correctly compute functions are expected to work _only_ on 
arrow data (arrays), which would make less convenient this function as a 
factory as its purpose is mostly to create a mask from literals.
   
   I think it would make sense to make it accept arrays too btw



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to