tustvold commented on code in PR #6590:
URL: https://github.com/apache/arrow-rs/pull/6590#discussion_r1808706665
##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -357,6 +357,12 @@ impl Buffer {
pub fn ptr_eq(&self, other: &Self) -> bool {
self.ptr == other.ptr && self.length == other.length
}
+
+ /// Register this [`Buffer`] with the provided [`MemoryPool`]
+ #[cfg(feature = "pool")]
+ pub fn claim(&self, pool: &dyn crate::MemoryPool) {
Review Comment:
I think this would make it harder to chain through to Arrays and RecordBatch
that may consist of multiple buffers and therefore reservations. It would also
mean potentially keeping around "duplicate" reservations for longer than
necessary, which would become even more problematic if the same buffer is used
multiple times.
What would be the use-case for the returned reservation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
