nealrichardson commented on a change in pull request #9685:
URL: https://github.com/apache/arrow/pull/9685#discussion_r593767079



##########
File path: r/R/dataset-format.R
##########
@@ -33,6 +33,10 @@
 #'   * "tsv", equivalent to passing `format = "text", delimiter = "\t"`
 #' * `...`: Additional format-specific options
 #'
+#'   `format = "csv"``:
+#'   * `compression`: Assume CSV files have been compressed with this codec.
+#'   Any options from [CsvParseOptions] may also be passed.
+#'
 #'   `format = "parquet"``:

Review comment:
       ```suggestion
   #'   `format = "parquet"`:
   ```
   Should fix this while we're here.

##########
File path: r/R/dataset-format.R
##########
@@ -33,6 +33,10 @@
 #'   * "tsv", equivalent to passing `format = "text", delimiter = "\t"`
 #' * `...`: Additional format-specific options
 #'
+#'   `format = "csv"``:

Review comment:
       This should be integrated with the `format = "text"` section at L47 
below (since "csv" actually is for any delimited text file and is an alias for 
"text" in this function). Also can you please add a crossref like `See [Codec] 
for supported compression libraries`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to