alamb commented on code in PR #6610:
URL: https://github.com/apache/arrow-rs/pull/6610#discussion_r1809024185
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -638,7 +647,9 @@ where
assert_eq!(views_builder.len(), len);
views_builder.finish()
} else {
- // TODO: the first u32::MAX can still be reused
+ // otherwise, create a new buffer for large strings
+ // TODO: the original buffer could still be used
+ // until the offset reaches `u32::max`.
Review Comment:
That is a clever idea 💯
FYI @XiangpengHao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
