zeroshade commented on code in PR #44495:
URL: https://github.com/apache/arrow/pull/44495#discussion_r1809769176
##########
cpp/src/arrow/c/bridge.cc:
##########
@@ -2511,4 +2516,333 @@ Result<std::shared_ptr<ChunkedArray>>
ImportDeviceChunkedArray(
return ImportChunked</*IsDevice=*/true>(stream, mapper);
}
+namespace {
+
+class AsyncRecordBatchIterator {
+ public:
+ struct State {
+ State(uint64_t queue_size, const DeviceMemoryMapper mapper)
+ : queue_size_{queue_size}, mapper_{std::move(mapper)} {}
+
+ const uint64_t queue_size_;
+ const DeviceMemoryMapper mapper_;
+ ArrowAsyncProducer* producer_;
+ DeviceAllocationType device_type_;
+
+ std::mutex mutex_;
+ std::shared_ptr<Schema> schema_;
+ std::condition_variable cv_;
+ std::queue<std::pair<ArrowAsyncTask, std::shared_ptr<KeyValueMetadata>>>
batches_;
+ bool end_of_stream_ = false;
+ Status error_{Status::OK()};
+ };
+
+ AsyncRecordBatchIterator(uint64_t queue_size, const DeviceMemoryMapper
mapper)
+ : state_{std::make_shared<State>(queue_size, std::move(mapper))} {}
+
+ explicit AsyncRecordBatchIterator(std::shared_ptr<State> state)
+ : state_{std::move(state)} {}
+
+ const std::shared_ptr<Schema>& schema() const { return state_->schema_; }
+
+ DeviceAllocationType device_type() const { return state_->device_type_; }
+
+ Result<RecordBatchWithMetadata> Next() {
Review Comment:
for the iterator yea, that was my intent. this is only exposed via
`MakeBackgroundGenerator` so that kinda enforces it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
