Yimche opened a new pull request, #44497:
URL: https://github.com/apache/arrow/pull/44497

   ### Rationale for this change
   This change is to address issue 
[#43985](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
 in which a bug in the behaviour of equality on pyarrow tables occurs when 
comparing a table containing a NaN value against itself.
   
   ### What changes are included in this PR?
   - Removed `if` block in `arrow/cpp/src/arrow/table.cc` that forced a return 
true if memory address of the two items being compared were equal, no matter 
the data stored inside.
   - Added test case.
   
   ### Are these changes tested?
   Yes. I put a test in the `arrow/python/pyarrow/tests/test_table.py` under 
the `test_table_from_pydict` function, as I wasn't sure and couldn't find where 
else to put the test.
   
   ### Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to