kou commented on code in PR #44498:
URL: https://github.com/apache/arrow/pull/44498#discussion_r1810118685
##########
c_glib/test/test-extension-data-type.rb:
##########
@@ -102,4 +102,11 @@ def test_wrap_chunked_array
extension_chunked_array.chunks.collect(&:class),
])
end
+
+ # GH-44478 test https://github.com/apache/arrow/issues/44478
+ def test_abstract_class_init
Review Comment:
```suggestion
def test_abstract_class
```
##########
c_glib/test/test-extension-data-type.rb:
##########
@@ -102,4 +102,11 @@ def test_wrap_chunked_array
extension_chunked_array.chunks.collect(&:class),
])
end
+
+ # GH-44478 test https://github.com/apache/arrow/issues/44478
Review Comment:
We don't need this comment.
##########
c_glib/test/test-extension-data-type.rb:
##########
@@ -102,4 +102,11 @@ def test_wrap_chunked_array
extension_chunked_array.chunks.collect(&:class),
])
end
+
+ # GH-44478 test https://github.com/apache/arrow/issues/44478
+ def test_abstract_class_init
+ assert_raise(TypeError) do
+ Arrow::ExtensionDataType.new.name
Review Comment:
Do we need this `.name`?
```suggestion
Arrow::ExtensionDataType.new
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
