trifleneurotic commented on code in PR #44503:
URL: https://github.com/apache/arrow/pull/44503#discussion_r1811712551
##########
cpp/src/arrow/filesystem/gcsfs.cc:
##########
@@ -962,7 +962,7 @@ Result<std::shared_ptr<io::OutputStream>>
GcsFileSystem::OpenAppendStream(
return Status::NotImplemented("Append is not supported in GCS");
}
-std::shared_ptr<GcsFileSystem> GcsFileSystem::Make(const GcsOptions& options,
+Result<std::shared_ptr<GcsFileSystem>> GcsFileSystem::Make(const GcsOptions&
options,
Review Comment:
Yes correct, as per the original issue: "For consistency with S3FileSystem"
which, incidentally, makes it consistent with other similar filesystems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
