itsjunetime commented on code in PR #6612:
URL: https://github.com/apache/arrow-rs/pull/6612#discussion_r1815630967
##########
parquet/src/arrow/async_reader/store.rs:
##########
@@ -180,10 +224,39 @@ mod tests {
let err = e.to_string();
assert!(
err.contains("not found: No such file or directory (os
error 2)"),
- "{}",
- err
+ "{err}",
);
}
}
}
+
+ #[tokio::test]
+ // We need to mark this with the `target_has_atomic` because the
spawned_tasks_count() fn is
+ // only available for that cfg
+ #[cfg(all(target_has_atomic = "64", tokio_unstable))]
Review Comment:
I don't think that would work. I'm not certain why, but
`ParquetObjectReader` seems to work fine regardless of whether or not IO is
'enabled' on its runtime. I was able to change the tests so they don't rely on
`tokio_unstable` anymore and (I think) still show what we want them to show, so
I'll push that in a minute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
