itsjunetime opened a new pull request, #6626:
URL: https://github.com/apache/arrow-rs/pull/6626
# Which issue does this PR close?
Some combinations of features cause compilation failures or test failures
where not necessary. For example, in the `parquet/src/file/metadata/reader.rs`
file, the `MetadataFetch` trait is only imported when `feature = "async"`, but
that trait exists under a module that's marked `feature = "arrow"`, so we need
to enable both those features to get it to work.
# Rationale for this change
There's nothing stopping people from using any combination of features from
this crate, so we should make sure they're all supported
# What changes are included in this PR?
This just adds extra `#[cfg()]` attributes where necessary to fix
compilation and test failures.
# Are there any user-facing changes?
No. It looks, on the surface, like we could be breaking the parquet crate
for people who have the `async` flag enabled with the `arrow` flag disabled,
but this crate doesn't compile in its current form for that combination, so
this won't actually adversely affect anyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
