tokoko commented on code in PR #2267:
URL: https://github.com/apache/arrow-adbc/pull/2267#discussion_r1816099072


##########
.github/workflows/rust.yml:
##########
@@ -70,6 +70,10 @@ jobs:
         run: |
           rustup toolchain install stable --no-self-update
           rustup default stable
+      - name: Install Protoc
+        uses: arduino/setup-protoc@v3
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}

Review Comment:
   - We can just do curl+unzip but it will require some logic to choose the 
right binary in order to work cross-platform.
   - Another option is to install `grpcio-tools` from pypi and then alias 
`protoc` to `python -m grpc_tools.protoc`, but that obviously requires python 
to be installed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to