alamb commented on issue #5052: URL: https://github.com/apache/arrow-rs/issues/5052#issuecomment-2437847293
> Alternatively we could forgo pointing to patched flatbuffers and just check the regenerated .rs in as a "manual" edit for now This is what I would recommend unless the changes needed to the compiler become more substantial. > where there is a spicy bash script that post-processes what the thrift compiler generates I think this is a good idea. While it is definitely an "old skool" approach to patches, it also has a lot of precident (though we can forgo the 🌶️ part lol) One common pattern is: 1. can check in a patch file (output of running `diff -du <actual output> <manual output>` 2. then have a script applies that diff via `patch` during the build This would keep the changes from stock flatbuffers in a separate file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
