bkirwi commented on PR #6524: URL: https://github.com/apache/arrow-rs/pull/6524#issuecomment-2437874900
Thanks for the thorough analysis on this! I had figured that since ArrayData validations were passing - which include the dictionary bounds checks - things were fine... and they are, but in a slightly more accidental way than I had appreciated. 😅 I suppose we'd have avoided this problem if we [took the "maximal" approach](https://github.com/apache/arrow-rs/issues/6510#issuecomment-2395194974), and generated a bunch of intermediate null buffers instead of removing "unnecessary" ones. An argument in favour of that approach I guess if we ever end up needing to revisit... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
