zeroshade commented on code in PR #170:
URL: https://github.com/apache/arrow-go/pull/170#discussion_r1816844738
##########
arrow/internal/testing/tools/fpunwind_arm64.s:
##########
@@ -0,0 +1,9 @@
+TEXT ·FPUnwind(SB), $0-0
Review Comment:
needs the apache license as comment on the top here
##########
arrow/memory/memory_test.go:
##########
@@ -123,3 +124,11 @@ func BenchmarkSet_8000(b *testing.B) {
func BenchmarkSet_8192(b *testing.B) {
benchmarkSet(b, 8192)
}
+
+func TestSetNoClobberFramePointer(t *testing.T) {
+ var b [8]byte
+ memory.Set(b[:], 0xff)
+ // We should be able to safely frame pointer unwind after calling this
+ // function
+ tools.FPUnwind()
Review Comment:
let's add a comment referencing the issue so that we understand why this
test exists in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
