alamb commented on a change in pull request #9703:
URL: https://github.com/apache/arrow/pull/9703#discussion_r593902253
##########
File path: rust/datafusion/src/logical_plan/builder.rs
##########
@@ -220,20 +260,28 @@ impl LogicalPlanBuilder {
}))
}
- /// Apply an aggregate
- pub fn aggregate(&self, group_expr: &[Expr], aggr_expr: &[Expr]) ->
Result<Self> {
- let mut all_expr = group_expr.to_vec();
Review comment:
it was even worse here -- *two* copies of each input expr were made --
one copy to pass to `validate_unique_names` and once to put on the
`LogicalPlanAggregate`.
Admittedly, removing the second copy doesn't require changing the signature
of this function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
