eitsupi commented on code in PR #2267:
URL: https://github.com/apache/arrow-adbc/pull/2267#discussion_r1817957897
##########
.github/workflows/rust.yml:
##########
@@ -70,6 +70,24 @@ jobs:
run: |
rustup toolchain install stable --no-self-update
rustup default stable
+ - name: Install Protoc
+ if: matrix.os == 'ubuntu-latest'
Review Comment:
```suggestion
if: runner.os == 'Linux'
```
##########
.github/workflows/rust.yml:
##########
@@ -70,6 +70,24 @@ jobs:
run: |
rustup toolchain install stable --no-self-update
rustup default stable
+ - name: Install Protoc
+ if: matrix.os == 'ubuntu-latest'
+ run: |
+ curl -LO
https://github.com/protocolbuffers/protobuf/releases/download/v28.3/protoc-28.3-linux-x86_64.zip
+ unzip protoc-28.3-linux-x86_64.zip -d $HOME/.local
+ echo "$HOME/.local/bin" >> "$GITHUB_PATH"
+ - name: Install Protoc
+ if: matrix.os == 'macos-13'
+ run: |
+ curl -LO
https://github.com/protocolbuffers/protobuf/releases/download/v28.3/protoc-28.3-osx-x86_64.zip
+ unzip protoc-28.3-osx-x86_64.zip -d $HOME/.local
+ echo "$HOME/.local/bin" >> "$GITHUB_PATH"
+ - name: Install Protoc
+ if: matrix.os == 'macos-latest'
+ run: |
+ curl -LO
https://github.com/protocolbuffers/protobuf/releases/download/v28.3/protoc-28.3-osx-aarch_64.zip
+ unzip protoc-28.3-osx-aarch_64.zip -d $HOME/.local
+ echo "$HOME/.local/bin" >> "$GITHUB_PATH"
Review Comment:
```suggestion
- name: Install Protoc
if: runner.os == 'macOS'
run: |
curl -LO
"https://github.com/protocolbuffers/protobuf/releases/download/v28.3/protoc-28.3-osx-$(uname
-m).zip"
unzip protoc-28.3-osx-x86_64.zip -d $HOME/.local
echo "$HOME/.local/bin" >> "$GITHUB_PATH"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]