Dandandan commented on code in PR #6632:
URL: https://github.com/apache/arrow-rs/pull/6632#discussion_r1818171776
##########
arrow-select/src/take.rs:
##########
@@ -50,6 +50,12 @@ use num::{One, Zero};
///
/// For selecting values by index from multiple arrays see
[`crate::interleave`]
///
+/// Note that the semantics of this kernel ("take" elements) is reflected on
the output
+/// values. The corresponding elements in the output array are the elements in
the input
+/// array at the indices specified in the indices array. This kernel, similar
to other
+/// kernels in this crate, does not guarantee the physical memory layout of
the output.
Review Comment:
I think this phrasing might be a bit confusing as the physical memory layout
(i.e. arrow arrays) is still guaranteed.
What isn't guaranteed is whether a fresh copy is created or buffers are
reused from existing array(s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
