bkietz commented on code in PR #44542:
URL: https://github.com/apache/arrow/pull/44542#discussion_r1819437147
##########
cpp/src/arrow/array/array_primitive.h:
##########
@@ -119,7 +129,7 @@ class NumericArray : public PrimitiveArray {
IteratorType end() const { return IteratorType(*this, length()); }
protected:
Review Comment:
The use of `protected` is odd here; nothing inherits from NumericArray
inside arrow. Is it intended to support user subclassing of NumericArray? Or
could we just mark NumericArray final? @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
