Dandandan commented on pull request #9704:
URL: https://github.com/apache/arrow/pull/9704#issuecomment-798985687
> @Dandandan I have mixed feelings about this change - I get the performance
improvement side, but in my opinion it makes the explain output less readable
by replacing the string to date cast with a date: `#l_shipdate GtEq
CAST(Utf8("1994-01-01") ` vs `#l_shipdate GtEq Date32("8766")`; for me the
string to date cast is much more readable and I can't really tell what date is
`Date32("8766")`
The `Date32("8766")` I don't find very elegant, but it's not really part of
this PR I would say. The formatting of constant dates could be improved to not
show the integer value of the date but a formatted yyyy-mm-dd date instead. I
agree the non-folded version is much easier to understand than this integer
value. The idea of the PR is of course to evaluate the constant expressions,
which in some cases might enable other optimizations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
