WillAyd commented on code in PR #668:
URL: https://github.com/apache/arrow-nanoarrow/pull/668#discussion_r1821631456
##########
meson.build:
##########
@@ -62,6 +62,16 @@ install_headers(
subdir: 'nanoarrow',
)
+install_headers(
Review Comment:
Very minor but you could do:
```python
installl_subdir('src/nanoarrow/hpp', 'nanoarrow/hpp')
```
here if you want all the headers installled
##########
src/nanoarrow/hpp/exception.hpp:
##########
Review Comment:
Since array_stream and buffer are "first class" nanoarrow objects, but
things like exceptions, operators, unique are not, maybe we should have another
directory structure for `nanoarrow/hpp/util` to house the latter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
