alamb commented on code in PR #6612:
URL: https://github.com/apache/arrow-rs/pull/6612#discussion_r1822382038
##########
parquet/src/errors.rs:
##########
@@ -107,6 +107,13 @@ impl From<str::Utf8Error> for ParquetError {
}
}
+#[cfg(test)]
+impl From<std::convert::Infallible> for ParquetError {
Review Comment:
Well, it can't be constructed, but it often does need to be "handled" (aka
to transform a `Result<.., Infallible>` to `Result<.., Error>` type expected by
an API)
I don't feel strongly about this particular code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
