zanmato1984 commented on code in PR #44394:
URL: https://github.com/apache/arrow/pull/44394#discussion_r1823746729
##########
cpp/src/arrow/compute/api_vector.cc:
##########
@@ -155,6 +155,11 @@ static auto kPairwiseOptionsType =
GetFunctionOptionsType<PairwiseOptions>(
DataMember("periods", &PairwiseOptions::periods));
static auto kListFlattenOptionsType =
GetFunctionOptionsType<ListFlattenOptions>(
DataMember("recursive", &ListFlattenOptions::recursive));
+static auto kReverseIndicesOptionsType =
GetFunctionOptionsType<ReverseIndicesOptions>(
+ DataMember("output_length", &ReverseIndicesOptions::output_length),
+ DataMember("output_type", &ReverseIndicesOptions::output_type));
+static auto kPermuteOptionsType = GetFunctionOptionsType<PermuteOptions>(
+ DataMember("output_length", &PermuteOptions::output_length));
Review Comment:
You are right. Scatter it should be. I'll update the naming soon.
In the meantime, what do you think about the category name "placement
functions"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
