EnricoMi commented on code in PR #44083:
URL: https://github.com/apache/arrow/pull/44083#discussion_r1824371716
##########
cpp/src/arrow/acero/source_node.cc:
##########
@@ -406,7 +407,7 @@ struct SchemaSourceNode : public SourceNode {
struct RecordBatchReaderSourceNode : public SourceNode {
RecordBatchReaderSourceNode(ExecPlan* plan, std::shared_ptr<Schema> schema,
arrow::AsyncGenerator<std::optional<ExecBatch>>
generator)
- : SourceNode(plan, schema, generator) {}
+ : SourceNode(plan, schema, generator, Ordering::Implicit()) {}
Review Comment:
Isn't this a bit too restrictive? This means all RecordBatch reader source
**always** preserve the implicit order, even if if users do not care? Shouldn't
this be configurable? What about other sources? Shouldn't the behaviour be the
same for any source?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
