Re: [PR] GH-44619: [GLib] Add GArrowDecimal32Scalar [arrow]

via GitHub Sun, 03 Nov 2024 12:41:04 -0800


kou commented on code in PR #44628:
URL: https://github.com/apache/arrow/pull/44628#discussion_r1827062140



##########
c_glib/arrow-glib/scalar.h:
##########
@@ -501,19 +501,35 @@ GARROW_AVAILABLE_IN_8_0
 GArrowMonthDayNano *
 
garrow_month_day_nano_interval_scalar_get_value(GArrowMonthDayNanoIntervalScalar
 *scalar);
 
+#define GARROW_TYPE_DECIMAL32_SCALAR (garrow_decimal32_scalar_get_type())
+GARROW_AVAILABLE_IN_5_0
+G_DECLARE_DERIVABLE_TYPE(
+  GArrowDecimal32Scalar, garrow_decimal32_scalar, GARROW, DECIMAL32_SCALAR, 
GArrowScalar)
+struct _GArrowDecimal32ScalarClass
+{
+  GArrowScalarClass parent_class;
+};
+
+GARROW_AVAILABLE_IN_5_0
+GArrowDecimal32Scalar *
+garrow_decimal32_scalar_new(GArrowDecimal32DataType *data_type, 
GArrowDecimal32 *value);
+GARROW_AVAILABLE_IN_5_0
+GArrowDecimal32 *
+garrow_decimal32_scalar_get_value(GArrowDecimal32Scalar *scalar);
+
 #define GARROW_TYPE_DECIMAL64_SCALAR (garrow_decimal64_scalar_get_type())
-GARROW_AVAILABLE_IN_19_0
+GARROW_AVAILABLE_IN_5_0

Review Comment:
   ```suggestion
   GARROW_AVAILABLE_IN_19_0
   ```



##########
c_glib/arrow-glib/scalar.h:
##########
@@ -501,19 +501,35 @@ GARROW_AVAILABLE_IN_8_0
 GArrowMonthDayNano *
 
garrow_month_day_nano_interval_scalar_get_value(GArrowMonthDayNanoIntervalScalar
 *scalar);
 
+#define GARROW_TYPE_DECIMAL32_SCALAR (garrow_decimal32_scalar_get_type())
+GARROW_AVAILABLE_IN_5_0

Review Comment:
   ```suggestion
   GARROW_AVAILABLE_IN_19_0
   ```



##########
c_glib/arrow-glib/scalar.h:
##########
@@ -501,19 +501,35 @@ GARROW_AVAILABLE_IN_8_0
 GArrowMonthDayNano *
 
garrow_month_day_nano_interval_scalar_get_value(GArrowMonthDayNanoIntervalScalar
 *scalar);
 
+#define GARROW_TYPE_DECIMAL32_SCALAR (garrow_decimal32_scalar_get_type())
+GARROW_AVAILABLE_IN_5_0
+G_DECLARE_DERIVABLE_TYPE(
+  GArrowDecimal32Scalar, garrow_decimal32_scalar, GARROW, DECIMAL32_SCALAR, 
GArrowScalar)
+struct _GArrowDecimal32ScalarClass
+{
+  GArrowScalarClass parent_class;
+};
+
+GARROW_AVAILABLE_IN_5_0
+GArrowDecimal32Scalar *
+garrow_decimal32_scalar_new(GArrowDecimal32DataType *data_type, 
GArrowDecimal32 *value);
+GARROW_AVAILABLE_IN_5_0
+GArrowDecimal32 *
+garrow_decimal32_scalar_get_value(GArrowDecimal32Scalar *scalar);
+
 #define GARROW_TYPE_DECIMAL64_SCALAR (garrow_decimal64_scalar_get_type())
-GARROW_AVAILABLE_IN_19_0
+GARROW_AVAILABLE_IN_5_0
 G_DECLARE_DERIVABLE_TYPE(
   GArrowDecimal64Scalar, garrow_decimal64_scalar, GARROW, DECIMAL64_SCALAR, 
GArrowScalar)
 struct _GArrowDecimal64ScalarClass
 {
   GArrowScalarClass parent_class;
 };
 
-GARROW_AVAILABLE_IN_19_0
+GARROW_AVAILABLE_IN_5_0

Review Comment:
   ```suggestion
   GARROW_AVAILABLE_IN_19_0
   ```



##########
c_glib/arrow-glib/scalar.h:
##########
@@ -501,19 +501,35 @@ GARROW_AVAILABLE_IN_8_0
 GArrowMonthDayNano *
 
garrow_month_day_nano_interval_scalar_get_value(GArrowMonthDayNanoIntervalScalar
 *scalar);
 
+#define GARROW_TYPE_DECIMAL32_SCALAR (garrow_decimal32_scalar_get_type())
+GARROW_AVAILABLE_IN_5_0
+G_DECLARE_DERIVABLE_TYPE(
+  GArrowDecimal32Scalar, garrow_decimal32_scalar, GARROW, DECIMAL32_SCALAR, 
GArrowScalar)
+struct _GArrowDecimal32ScalarClass
+{
+  GArrowScalarClass parent_class;
+};
+
+GARROW_AVAILABLE_IN_5_0

Review Comment:
   ```suggestion
   GARROW_AVAILABLE_IN_19_0
   ```



##########
c_glib/arrow-glib/scalar.h:
##########
@@ -501,19 +501,35 @@ GARROW_AVAILABLE_IN_8_0
 GArrowMonthDayNano *
 
garrow_month_day_nano_interval_scalar_get_value(GArrowMonthDayNanoIntervalScalar
 *scalar);
 
+#define GARROW_TYPE_DECIMAL32_SCALAR (garrow_decimal32_scalar_get_type())
+GARROW_AVAILABLE_IN_5_0
+G_DECLARE_DERIVABLE_TYPE(
+  GArrowDecimal32Scalar, garrow_decimal32_scalar, GARROW, DECIMAL32_SCALAR, 
GArrowScalar)
+struct _GArrowDecimal32ScalarClass
+{
+  GArrowScalarClass parent_class;
+};
+
+GARROW_AVAILABLE_IN_5_0
+GArrowDecimal32Scalar *
+garrow_decimal32_scalar_new(GArrowDecimal32DataType *data_type, 
GArrowDecimal32 *value);
+GARROW_AVAILABLE_IN_5_0

Review Comment:
   ```suggestion
   GARROW_AVAILABLE_IN_19_0
   ```



##########
c_glib/arrow-glib/scalar.h:
##########
@@ -501,19 +501,35 @@ GARROW_AVAILABLE_IN_8_0
 GArrowMonthDayNano *
 
garrow_month_day_nano_interval_scalar_get_value(GArrowMonthDayNanoIntervalScalar
 *scalar);
 
+#define GARROW_TYPE_DECIMAL32_SCALAR (garrow_decimal32_scalar_get_type())
+GARROW_AVAILABLE_IN_5_0
+G_DECLARE_DERIVABLE_TYPE(
+  GArrowDecimal32Scalar, garrow_decimal32_scalar, GARROW, DECIMAL32_SCALAR, 
GArrowScalar)
+struct _GArrowDecimal32ScalarClass
+{
+  GArrowScalarClass parent_class;
+};
+
+GARROW_AVAILABLE_IN_5_0
+GArrowDecimal32Scalar *
+garrow_decimal32_scalar_new(GArrowDecimal32DataType *data_type, 
GArrowDecimal32 *value);
+GARROW_AVAILABLE_IN_5_0
+GArrowDecimal32 *
+garrow_decimal32_scalar_get_value(GArrowDecimal32Scalar *scalar);
+
 #define GARROW_TYPE_DECIMAL64_SCALAR (garrow_decimal64_scalar_get_type())
-GARROW_AVAILABLE_IN_19_0
+GARROW_AVAILABLE_IN_5_0
 G_DECLARE_DERIVABLE_TYPE(
   GArrowDecimal64Scalar, garrow_decimal64_scalar, GARROW, DECIMAL64_SCALAR, 
GArrowScalar)
 struct _GArrowDecimal64ScalarClass
 {
   GArrowScalarClass parent_class;
 };
 
-GARROW_AVAILABLE_IN_19_0
+GARROW_AVAILABLE_IN_5_0
 GArrowDecimal64Scalar *
 garrow_decimal64_scalar_new(GArrowDecimal64DataType *data_type, 
GArrowDecimal64 *value);
-GARROW_AVAILABLE_IN_19_0
+GARROW_AVAILABLE_IN_5_0

Review Comment:
   ```suggestion
   GARROW_AVAILABLE_IN_19_0
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] GH-44619: [GLib] Add GArrowDecimal32Scalar [arrow]

Reply via email to