tustvold commented on code in PR #6673: URL: https://github.com/apache/arrow-rs/pull/6673#discussion_r1827839121
########## arrow-array/src/array/byte_view_array.rs: ########## @@ -50,11 +54,18 @@ use super::ByteArrayType; /// /// [`ByteView`]: arrow_data::ByteView /// -/// # Notes +/// # Use the [`eq`] kernel to compare the logical content. +/// +/// Comparing two `GenericByteViewArray` using PartialEq compares by structure +/// (the `u128`s) and contents of the buffers, not by logical content. As there Review Comment: IMO this is a bug, the other array data equality implementations compute logical equality -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
