alamb opened a new issue, #6679:
URL: https://github.com/apache/arrow-rs/issues/6679

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   
   >  Comparing two `GenericByteViewArray` using PartialEq compares by structure
   >  (the `u128`s) and contents of the buffers, not by logical content. As 
there
   
   As @tustvold points out on 
https://github.com/apache/arrow-rs/pull/6673/files#r1827839121 this is 
inconsistent with how `PartialEq` is implemented for other arrays, which 
compare based on ArrayData which compares based on equality:
   
   
https://github.com/apache/arrow-rs/blob/ebcc4a585136cd1d9696c38c41f71c9ced181f57/arrow-data/src/data.rs#L1777-L1781
   
   
   **Describe the solution you'd like**
   Implement `PartialEq` for `GenericByteViewArray` that compares two arrays on 
logical value rather than physical representation
   
   **Describe alternatives you've considered**
   Add manual impl of `PartialEq` to `GenericByteViewArray`
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to