alamb commented on code in PR #6426:
URL: https://github.com/apache/arrow-rs/pull/6426#discussion_r1828329317
##########
arrow-ipc/Cargo.toml:
##########
@@ -39,7 +39,7 @@ arrow-buffer = { workspace = true }
arrow-cast = { workspace = true }
arrow-data = { workspace = true }
arrow-schema = { workspace = true }
-flatbuffers = { version = "24.3.25", default-features = false }
+flatbuffers = { default-features = false, git =
"https://github.com/google/flatbuffers.git";, rev =
"49061f8c7c99363eeea25c5e4337ebb499928467" }
Review Comment:
In fact I think we can't actually release a fix for arrow with this fix as
the upstream change adds a new method `alignment` -- it doesn't just update the
generated code I think
##########
arrow-ipc/Cargo.toml:
##########
@@ -39,7 +39,7 @@ arrow-buffer = { workspace = true }
arrow-cast = { workspace = true }
arrow-data = { workspace = true }
arrow-schema = { workspace = true }
-flatbuffers = { version = "24.3.25", default-features = false }
+flatbuffers = { default-features = false, git =
"https://github.com/google/flatbuffers.git";, rev =
"49061f8c7c99363eeea25c5e4337ebb499928467" }
Review Comment:
When I reverted this pin it fails to compile
```
error[E0433]: failed to resolve: could not find `PushAlignment` in
`flatbuffers`
--> arrow-ipc/src/gen/File.rs:71:22
|
71 | flatbuffers::PushAlignment::new(8)
| ^^^^^^^^^^^^^ could not find `PushAlignment` in
`flatbuffers`
```
Thus I think we need to wait for the next flatbuffers release 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
