paleolimbot commented on code in PR #2219:
URL: https://github.com/apache/arrow-adbc/pull/2219#discussion_r1829761285
##########
c/driver/postgresql/postgres_type.h:
##########
@@ -111,7 +111,11 @@ enum class PostgresTypeId {
kXid8,
kXid,
kXml,
- kUserDefined
+ kUserDefined,
+ // This is not an actual type, but there are cases where all we have is an
Oid
+ // that was not inserted into the type resolver. We can't use "unknown" or
"opaque"
+ // or "void" because those names show up in actual pg_type tables.
+ kUnnamedArrowOpaque
Review Comment:
A warning would be helpful when we get there...for now I think it's a little
nicer as `arrow.opaque` because then you can inspect it in context and see a
bit of the data to maybe understand what went wrong. For the case that led me
to add this, even reconnecting or lazy updating wouldn't have helped (the
backend pg_type table is just missing a type definition for GEOMETRY).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
